Re: [PATCH Resend 1/4] staging: dgap: Include version.h header in dgap_kcompat.h

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 28, 2013 at 10:35:46AM +0530, Sachin Kamat wrote:
> Include version.h header file as detected by versioncheck.
> 
> Cc: Lidza Louina <lidza.louina@xxxxxxxxx>
> Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx>
> ---
>  drivers/staging/dgap/dgap_kcompat.h |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/dgap/dgap_kcompat.h b/drivers/staging/dgap/dgap_kcompat.h
> index 8ebf4b7..f21c8d7 100644
> --- a/drivers/staging/dgap/dgap_kcompat.h
> +++ b/drivers/staging/dgap/dgap_kcompat.h
> @@ -28,6 +28,8 @@
>  #ifndef __DGAP_KCOMPAT_H
>  #define __DGAP_KCOMPAT_H
>  
> +#include <linux/version.h>

Please just remove the KERNEL_VERSION check, and the use of the macro in
this file entirely, as it's pointless here.

thanks,

greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux