On Fri, Aug 23, 2013 at 4:40 AM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote: > On Wed, Aug 21, 2013 at 01:27:15PM -0400, Lidza Louina wrote: >> This patch fixes the error: "foo* bar" should be "foo *bar". >> > > I have a nit pick about this changelog. It's not something to > resend over, of course, but for future patches. The word "fix" > should only be used for bugfixes. The word "clean up" is the > opposite and should not be used for changes which affect how the > code works. Ahh, ok. I see, that makes sense. > It's pretty much kernel standard to separate fixes and cleanups as > two different things. > https://www.google.com/search?q=fix+clean+ups+linux+kernel > > A "syntax error" means something that breaks the compile. So I was > expecting a fix for the compile. A better subject would be: > "[PATCH] staging: dgnc: tty.c: clean up pointer white space" Okay, I'll change my language when sending more patches that clean up code. Thanks for the tip. =] _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
