Re: [PATCH 3/3] staging: dwc2: add microframe scheduler from downstream Pi kernel

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Paul & Dom,

I haven't got time to look closely right now, but at first glance most
of my comments have been resolved. One thing that is still in there, is
this piece of code for which I'm not sure if it is really related to the
topic of the patch:


> @@ -780,6 +784,10 @@ static void dwc2_assign_and_init_hc(struct dwc2_hsotg *hsotg,
>  	chan->data_pid_start = qh->data_toggle;
>  	chan->multi_count = 1;
>  
> +	if ((urb->actual_length < 0 || urb->actual_length > urb->length) &&
> +	    !dwc2_hcd_is_pipe_in(&urb->pipe_info))
> +		urb->actual_length = urb->length;
> +
>  	if (hsotg->core_params->dma_enable > 0) {
>  		chan->xfer_dma = urb->dma + urb->actual_length;
>  

Paul, did you try the patch without this hunk?
Dom, can you tell use why this hunk is needed?

Gr.

Matthijs
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux