Re: [PATCH 2/2] Staging: BCM: Removed more whitespace/Errors

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2013-08-08 at 23:44 +0300, Dan Carpenter wrote:
> On Thu, Aug 08, 2013 at 06:03:49PM +0100, Paul McQuade wrote:
> > -int InterfaceFileDownload( PVOID psIntfAdapter,
> > -                        struct file *flp,
> > -                        unsigned int on_chip_loc);
> > +int InterfaceFileDownload(PVOID psIntfAdapter,
> > +						struct file *flp,
> > +						unsigned int on_chip_loc);
> 
> 
> The very first line in this patch is totally wrong...  :(
> 
> This is an automated patch.

It is?

It doesn't look like an automated patch to me.
It looks like there are too many different style
choices for it to have been done by a machine.

Why do you think that?

Paul, how did you create this patch?

Dan, if you get a chance, could you try to use
checkpatch with the --fix option with specific
--types like SPACING and PARENTHESIS_ALIGNMENT
and tell me if you think it's OK?

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux