RE: [PATCH 3/4] staging: comedi: drivers: use comedi_dio_insn_config() for simple cases

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, August 06, 2013 9:07 AM, H Hartley Sweeten wrote:
> On Tuesday, August 06, 2013 6:38 AM, Ian Abbott wrote:
>> This won't work for ni_65xx as the DIO subdevice has 96 channels, but 
>> s->io_bits only supports 32 channels.
>
> Ah, I thought I caught all the > 32 channel uses. Missed this one due to the
> use of the boardinfo.
>
> It looks like the original driver has a bug anyway since it uses the s->io_bits
> in the (*insn_config).

Oops.. Ignore that comment. I was looking at a different driver when I saw the
s->io_bits usage.

Regards,
Hartley

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux