Re: [PATCH] staging/zcache: Fix memory leak while dropping an o2net_sock_container object

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Aug 04, 2013 at 08:06:20PM +0800, Jeff Liu wrote:
> From: Jie Liu <jeff.liu@xxxxxxxxxx>
> 
> Free sc->sc_page when releasing a struct o2net_sock_container
> object to avoid memory leaks.
> 
> This issue has been fixed by Younger Liu for OCFS2, so I sync
> that patch to zcache as we share the same network code base.

Looks ok to me.

> 
> Cc: Younger Liu <younger.liu@xxxxxxxxxx>
> Cc: Bob Liu <bob.liu@xxxxxxxxxx>
> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
> Cc: Konrad Rzeszutek Wilk <konrad.wilk@xxxxxxxxxx>
> Signed-off-by: Jie Liu <jeff.liu@xxxxxxxxxx>
> ---
>  drivers/staging/zcache/ramster/tcp.c |    3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/staging/zcache/ramster/tcp.c b/drivers/staging/zcache/ramster/tcp.c
> index f6e1e52..f74881e 100644
> --- a/drivers/staging/zcache/ramster/tcp.c
> +++ b/drivers/staging/zcache/ramster/tcp.c
> @@ -403,6 +403,9 @@ static void sc_kref_release(struct kref *kref)
>  	sc->sc_node = NULL;
>  
>  	r2net_debug_del_sc(sc);
> +
> +	if (sc->sc_page)
> +		__free_page(sc->sc_page);
>  	kfree(sc);
>  }
>  
> -- 
> 1.7.9.5
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux