Re: [PATCH] Staging: wlags49_h2: fixed 80 line character and white space issue in ap_h2.c Fixed various coding style warnings found by the checkpatch.pl tool

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hello Evan,

When reformatting the array containing the firmware data it may be easier to use 8 bytes per row. It is currently it is 16 bytes per row (overrunning the 80 characters/line) and this just means cutting each row exactly in half. In your first proposal it was completely reformatted to an odd 11 bytes per row which makes comparison with the original during review much harder and it is also easier to make mistakes.

Kind regards,

Henk.

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux