On Fri, Aug 02, 2013 at 10:20:28AM +0800, Xiong Zhou wrote: > > > On Wed, 31 Jul 2013, Greg Kroah-Hartman wrote: > > > On Wed, Jul 31, 2013 at 10:30:41AM +0800, Xiong Zhou wrote: > > > From: Xiong Zhou <jencce.kernel@xxxxxxxxx> > > > > > > First version of this patch makes LUSTRE_FS depends on BLOCK. Second > > > version makes only lloop depends on BLOCK with a config option for this > > > dependence, and remove unnecessary jdb header files which depends on > > > BLOCK. > > > > > > This version removes the wrapper ll_unregister_blkdev which depends on > > > BLOCK in header and just call unregister_blkdev in lloop.c based on Peng > > > Tao's comment. > > > > This isn't all needed in the patch changelog info, just say what it > > does. > > > > Also, it doesn't apply for some reason, care to refresh this against my > > latest tree and resend? > > > > thanks, > > > > greg k-h > > > > OK, this patch is based on the staging-next branch of your staging tree. > > > From: Xiong Zhou <jencce.kernel@xxxxxxxxx> > > Add a config option for llite/lloop in lustre driver, making it > depends on BLOCK to fix this better: > drivers/staging/lustre/lustre/fid/../include/linux/lustre_compat25.h:117:2: > error: implicit declaration of function ‘unregister_blkdev’ > > Also, remove the wrapper ll_unregister_blkdev which depends on BLOCK in > the header and just call unregister_blkdev in lloop.c based on Peng Tao's > comment. Drop the redundant dependency on STAGING for LUSTRE_FS, remove > some unnecessary jdb header files which depends on BLOCK btw. > > Signed-off-by: Xiong Zhou <jencce.kernel@xxxxxxxxx> > Reviewed-by: Peng Tao <tao.peng@xxxxxxx> Please resend this so I don't have to edit the body of the email, and the Subject: line as well. Also, you have a bunch of trailing whitespace in your changelog comments, are you sure you want/need that? thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
