On Thu, Aug 01, 2013 at 02:03:13PM -0400, lidza.louina@xxxxxxxxx wrote: > This patch adds the DGNC driver. This is a TTY Serial Port > Driver for the Digi International Neo and Classic PCI based product > line by Digi International <http://www.digi.com>. > > Signed-off-by: Lidza Louina <lidza.louina@xxxxxxxxx> Looks good, but a few minor questions. This is the "raw" driver that Mark pointed you at, right? You haven't changed anything for it yet? Also, a short "this is not hooked up to the build system because it doesn't build" would be nice to add to the changelog area as most people will wonder why it's not actually selectable to be built at this point in time. thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel