Hi, Here's some mechanical cleanups to eliminate typedefs. The only remaining one is cvmx_usb_callback_func_t which probably is better to be left as is. Comments are adjusted/re-formatted for each type at the same time. No functional changes. Tested with EdgeRouter Lite + USB mass storage. Aaro Koskinen (20): staging: octeon-usb: cvmx_usb_speed_t -> enum cvmx_usb_speed staging: octeon-usb: cvmx_usb_transfer_t -> enum cvmx_usb_transfer staging: octeon-usb: cvmx_usb_direction_t -> enum cvmx_usb_direction staging: octeon-usb: cvmx_usb_complete_t -> enum cvmx_usb_complete staging: octeon-usb: cvmx_usb_callback_t -> enum cvmx_usb_callback staging: octeon-usb: cvmx_usb_initialize_flags_t -> enum cvmx_usb_initialize_flags staging: octeon-usb: cvmx_usb_pipe_flags_t -> enum cvmx_usb_pipe_flags staging: octeon-usb: cvmx_usb_isochronous_flags_t -> enum cvmx_usb_isochronous_flags staging: octeon-usb: cvmx_usb_transaction_flags_t -> enum cvmx_usb_transaction_flags staging: octeon-usb: cvmx_usb_stage_t -> enum cvmx_usb_stage staging: octeon-usb: cvmx_usb_port_status_t -> struct cvmx_usb_port_status staging: octeon-usb: cvmx_usb_iso_packet_t -> struct cvmx_usb_iso_packet staging: octeon-usb: cvmx_usb_state_t -> struct cvmx_usb_state staging: octeon-usb: cvmx_usb_transaction_t -> struct cvmx_usb_transaction staging: octeon-usb: cvmx_usb_pipe_t -> struct cvmx_usb_pipe staging: octeon-usb: cvmx_usb_pipe_list_t -> struct cvmx_usb_pipe_list staging: octeon-usb: cvmx_usb_tx_fifo_t -> struct cvmx_usb_tx_fifo staging: octeon-usb: cvmx_usb_internal_state_t -> struct cvmx_usb_internal_state staging: octeon-usb: cvmx_usb_control_header_t -> union cvmx_usb_control_header staging: octeon-usb: eliminate remaining typedef unions drivers/staging/octeon-usb/cvmx-usb.c | 575 +++++++++++++++------------ drivers/staging/octeon-usb/cvmx-usb.h | 386 +++++++++++------- drivers/staging/octeon-usb/cvmx-usbcx-defs.h | 23 -- drivers/staging/octeon-usb/cvmx-usbnx-defs.h | 2 - drivers/staging/octeon-usb/octeon-hcd.c | 33 +- 5 files changed, 574 insertions(+), 445 deletions(-) -- 1.8.3.2 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel