Acked-by: Andres Salomon <dilinger@xxxxxxxxxx> On Tue, 30 Jul 2013 20:11:34 +0200 Jens Frederich <jfrederich@xxxxxxxxx> wrote: > The FB_OLPC_DCON help section is to short according to checkpatch.pl. > We want more information about the controller type, its task, its > video pipeline position and so on. > > There are no style issues, remove checkpatch.pl TODO entry. > > Signed-off-by: Jens Frederich <jfrederich@xxxxxxxxx> > > diff --git a/drivers/staging/olpc_dcon/Kconfig > b/drivers/staging/olpc_dcon/Kconfig index fe40e0b..2ff015d 100644 > --- a/drivers/staging/olpc_dcon/Kconfig > +++ b/drivers/staging/olpc_dcon/Kconfig > @@ -4,9 +4,14 @@ config FB_OLPC_DCON > select I2C > select BACKLIGHT_CLASS_DEVICE > ---help--- > - Add support for the OLPC XO DCON controller. This > controller is > - only available on OLPC platforms. Unless you have one of > these > - platforms, you will want to say 'N'. > + In order to support very low power operation, the XO > laptop uses a > + secondary Display CONtroller, or DCON. This secondary > controller > + is present in the video pipeline between the primary > display > + controller (integrate into the processor or chipset) and > the LCD > + panel. It allows the main processor/display controller to > be > + completely powered off while still retaining an image on > the display. > + This controller is only available on OLPC platforms. > Unless you have > + one of these platforms, you will want to say 'N'. > > config FB_OLPC_DCON_1 > bool "OLPC XO-1 DCON support" > diff --git a/drivers/staging/olpc_dcon/TODO > b/drivers/staging/olpc_dcon/TODO index 35f9cda..f378e84 100644 > --- a/drivers/staging/olpc_dcon/TODO > +++ b/drivers/staging/olpc_dcon/TODO > @@ -1,5 +1,4 @@ > TODO: > - - checkpatch.pl cleanups > - see if vx855 gpio API can be made similar enough to cs5535 > so we can share more code > - allow simultaneous XO-1 and XO-1.5 support _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel