Re: [PATCH 09/20] staging: octeon-usb: cvmx-usb: replace long udelays with mdelays

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> > > -    cvmx_wait_usec(1000);
> > > +    mdelay(1);
> > 
> > why not udelay here?
> 
> It's long enough so that mdelay can be used. :)

sorry, I was meaning usleep_range :)

> > > -    cvmx_wait_usec(50000);
> > > +    mdelay(50);
> > 
> > and why not msleep here?
> 
> cvmx_usb_enable() is called holding a spinlock with interrupts disabled.
> We cannot sleep here.

Arrgghhh! OK, makes sense then.

Thanks,
Andi
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux