On Fri, Jul 26, 2013 at 10:32:33AM +0300, Dan Carpenter wrote: > On Fri, Jul 26, 2013 at 10:15:55AM +0800, Wei Yongjun wrote: > > From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx> > > > > A spin lock is taken here so we should use GFP_ATOMIC. > > > > Acked-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx> > > But the locking here is really odd and pointless. usb_submit_urb() > returns asynchronously before the data has been sent, so there is > almost no point in locking around it. There's no guarantee it will return before the complete() call is made, so the data could be sent and then received before the call returns. Not to say that the locking doesn't seem wrong, I agree with that... thanks, greg k-h _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
