On 2013-07-25 17:37, H Hartley Sweeten wrote:
On Thursday, July 25, 2013 5:50 AM, Ian Abbott wrote:
On 2013-07-24 19:47, H Hartley Sweeten wrote:
The comedi_subdevice pointer is not used in this function. Its simply
passed on to pcmuio_handle_intr_subdev(). That function then needs to
calculate the 'asic' associated with the subdevice. Just pass on the
'asic' instead and let pcmuio_handle_intr_subdev() get the subdevice
from that.
Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
Cc: Ian Abbott <abbotti@xxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
In that case, it would make sense to rename the function to
pcmuio_handle_intr_asic().
Or just pcmuio_handle_pending_intr(), then the comment could also be
removed.
This could be a separate patch. But I can rebase the series it you wish.
I wouldn't bother rebasing and it's not that important. A separate
patch to rename it would be nice if you have the time.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
