Re: [PATCH 00/30] staging: comedi: usbdux: cleanup driver take 2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2013-07-26 00:02, H Hartley Sweeten wrote:
Patches 1-32 of [PATCH 00/53] staging: comedi: usbdux: cleanup driver
have already be applied to Greg Kroah-Hartman's staging tree. This
continues the cleanup of the usbdux comedi driver from that point.

Patches 1, 2, 7, 9, and 15 have been updated to address an issue
pointed out by Ian Abbott concerning the urb completion routine
executing before the *_cmd_running flag has been set.

The last 9 patches in this series are new. These have been added to
work toward merging the usbduxfast driver into this one.

H Hartley Sweeten (30):
   staging: comedi: usbdux: tidy up usbdux_ai_inttrig()
   staging: comedi: usbdux: tidy up usbdux_ai_cmd()
   staging: comedi: usbdux: tidy up usbdux_ai_insn_read()
   staging: comedi: usbdux: clarify bipolar ai data
   staging: comedi: usbdux: tidy up usbdux_ao_insn_read()
   staging: comedi: usbdux: tidy up usbdux_ao_insn_write()
   staging: comedi: usbdux: tidy up usbdux_ao_inttrig()
   staging: comedi: usbdux: tidy up usbdux_ao_cmd()
   staging: comedi: usbdux: tidy up usbdux_dio_insn_config()
   staging: comedi: usbdux: tidy up usbdux_dio_insn_bits()
   staging: comedi: usbdux: fix usbdux_counter_read()
   staging: comedi: usbdux: fix usbdux_counter_write()
   staging: comedi: usbdux: tidy up usbdux_pwm_stop()
   staging: comedi: usbdux: fix usbdux_pwm_cancel()
   staging: comedi: usbdux: fix usbdux_pwm_start()
   staging: comedi: usbdux: tidy up unlink and stop helpers
   staging: comedi: usbdux: use the stop helpers in the detach
   staging: comedi: usbdux: remove the usb endpoint defines
   staging: comedi: usbdux: remove some unused defines
   staging: comedi: usbdux: move usbdux_firmware_upload()
   staging: comedi: usbdux: clarify bipolar ai data in usbduxsub_ai_isoc_irq()
   staging: comedi: usbdux: rename private data variables
   staging: comedi: usbdux: cleanup the private data 'outBuffer'
   staging: comedi: usbdux: simplify initializing the ao urb transfer_buffer
   staging: comedi: usbdux: remove unnecessary check in usbdux_ai_cmd()
   staging: comedi: usbdux: remove unnecessary check in usbdux_ao_cmd()
   staging: comedi: usbdux: 'dac_commands' does not need to be kzalloc()'d
   staging: comedi: usbdux: remove unused define
   staging: comedi: usbdux: move and rename the bulk transfer commands
   staging: comedi: usbdux: consolidate usbduxsub_unlink_{in,out}urbs()

  drivers/staging/comedi/drivers/usbdux.c | 1094 ++++++++++++++-----------------
  1 file changed, 494 insertions(+), 600 deletions(-)


All looks good!

Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux