On 2013-07-24 22:05, H Hartley Sweeten wrote:
Move all the usb_driver (*probe) and (*disconnect) operations into the comedi_driver (*auto_attach) and (*detach). This allows the per device private data to be kzalloc()'d and removes the 16 device limitation. Remove all the unnecessary information from the private data. Tidy up the driver to remove any cruft. H Hartley Sweeten (53): staging: comedi: usbdux: rename struct usbduxsub staging: comedi: usbdux: remove the usb_driver (*probe) noise staging: comedi: usbdux: tidy up usbdux_usb_probe() staging: comedi: usbdux: move usb buffer allocation into new function staging: comedi: usbdux: push usb (*disconnect) into comedi (*detach) staging: comedi: usbdux: push usb (*probe) into comedi (*auto_attach) staging: comedi: usbdux: remove unnecessary tidy_up() calls staging: comedi: usbdux: cleanup the (*detach) staging: comedi: usbdux: remove NOISY_DUX_DEBUGBUG staging: comedi: usbdux: tidy up usbdux_attach_common() staging: comedi: usbdux: absorb usbdux_attach_common into caller staging: comedi: usbdux: tidy up usbduxsub_ai_isoc_irq() staging: comedi: usbdux: tidy up usbduxsub_ao_isoc_irq() staging: comedi: usbdux: tidy up usbduxsub_pwm_irq() staging: comedi: usbdux: remove the SUBDEV_* defines staging: comedi: usbdux: tidy up the comedi_lrange tables staging: comedi: usbdux: remove dev_printk() noise staging: comedi: usbdux: tidy up usbduxsub_submit_inurbs() staging: comedi: usbdux: tidy up usbduxsub_submit_outurbs() staging: comedi: usbdux: tidy up usbduxsub_submit_pwm_urbs() staging: comedi: usbdux: remove 'comedidev' from private data staging: comedi: usbdux: remove 'interface' from private data staging: comedi: usbdux: tidy up send_dux_commands() staging: comedi: usbdux: tidy up receive_dux_commands() staging: comedi: usbdux: pass comedi_device pointer to usbdux_alloc_usb_buffers() staging: comedi: usbdux: remove usb_device back pointer from private data staging: comedi: usbdux: remove 'ifnum' from the private data staging: comedi: usbdux: make private data flags bit-fields staging: comedi: usbdux: tidy up usbdux_ai_stop() staging: comedi: usbdux: tidy up usbdux_ai_cancel() staging: comedi: usbdux: tidy up usbdux_ao_stop() staging: comedi: usbdux: tidy up usbdux_ao_cancel() staging: comedi: usbdux: tidy up usbdux_ai_inttrig() staging: comedi: usbdux: tidy up usbdux_ai_cmd() staging: comedi: usbdux: tidy up usbdux_ai_insn_read() staging: comedi: usbdux: clarify bipolar ai data staging: comedi: usbdux: tidy up usbdux_ao_insn_read() staging: comedi: usbdux: tidy up usbdux_ao_insn_write() staging: comedi: usbdux: tidy up usbdux_ao_inttrig() staging: comedi: usbdux: tidy up usbdux_ao_cmd() staging: comedi: usbdux: tidy up usbdux_dio_insn_config() staging: comedi: usbdux: tidy up usbdux_dio_insn_bits() staging: comedi: usbdux: fix usbdux_counter_read() staging: comedi: usbdux: fix usbdux_counter_write() staging: comedi: usbdux: tidy up usbdux_pwm_stop() staging: comedi: usbdux: fix usbdux_pwm_cancel() staging: comedi: usbdux: tidy up usbdux_pwm_start() staging: comedi: usbdux: tidy up unlink and stop helpers staging: comedi: usbdux: use the stop helpers in the detach staging: comedi: usbdux: remove the usb endpoint defines staging: comedi: usbdux: remove some unused defines staging: comedi: usbdux: move usbdux_firmware_upload() staging: comedi: usbdux: clarify bipolar ai data in usbduxsub_ai_isoc_irq() drivers/staging/comedi/drivers/usbdux.c | 2265 +++++++++++-------------------- 1 file changed, 822 insertions(+), 1443 deletions(-)
I commented on patches 33, 34, 39, 40 and 47 to do with the ordering of setting the foo_cmd_start variables and submitting the URBs, but the remaining look okay.
I wish I'd noticed the ordering problem when the patches for usbduxfast and usbduxsigma were submitted!
-- -=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=- -=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=- _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
