On 2013-07-24 19:11, H Hartley Sweeten wrote:
This driver is a great example of "bad kernel code"...
It greatly abuses the comedi API and will not work without patching
the comedi core. It's CodingStyle is terrible. It uses floating point
math. And, it's almost impossible to read.
A Kconfig option to enable this driver isn't even available.
Tidy it up a bit so it does not rely on any other source files then
remove it cleanly.
H Hartley Sweeten (4):
staging: comedi: addi_apci_1710: fix some compile errors/warnings
staging: comedi: addi_apci_1710: separate from addi_common.h
staging: comedi: addi_apci_1710: delete driver
staging: comedi: addi_common.h: cleanup after removal of
addi_apci_1710
.../comedi/drivers/addi-data/APCI1710_82x54.c | 1068 ----
.../comedi/drivers/addi-data/APCI1710_Chrono.c | 2050 --------
.../comedi/drivers/addi-data/APCI1710_Dig_io.c | 1037 ----
.../comedi/drivers/addi-data/APCI1710_INCCPT.c | 5461 --------------------
.../comedi/drivers/addi-data/APCI1710_Inp_cpt.c | 866 ----
.../comedi/drivers/addi-data/APCI1710_Pwm.c | 3582 -------------
.../comedi/drivers/addi-data/APCI1710_Ssi.c | 845 ---
.../comedi/drivers/addi-data/APCI1710_Tor.c | 2065 --------
.../comedi/drivers/addi-data/APCI1710_Ttl.c | 1044 ----
.../staging/comedi/drivers/addi-data/addi_common.h | 169 -
.../comedi/drivers/addi-data/hwdrv_APCI1710.c | 1314 -----
drivers/staging/comedi/drivers/addi_apci_1710.c | 99 -
12 files changed, 19600 deletions(-)
delete mode 100644 drivers/staging/comedi/drivers/addi-data/APCI1710_82x54.c
delete mode 100644 drivers/staging/comedi/drivers/addi-data/APCI1710_Chrono.c
delete mode 100644 drivers/staging/comedi/drivers/addi-data/APCI1710_Dig_io.c
delete mode 100644 drivers/staging/comedi/drivers/addi-data/APCI1710_INCCPT.c
delete mode 100644 drivers/staging/comedi/drivers/addi-data/APCI1710_Inp_cpt.c
delete mode 100644 drivers/staging/comedi/drivers/addi-data/APCI1710_Pwm.c
delete mode 100644 drivers/staging/comedi/drivers/addi-data/APCI1710_Ssi.c
delete mode 100644 drivers/staging/comedi/drivers/addi-data/APCI1710_Tor.c
delete mode 100644 drivers/staging/comedi/drivers/addi-data/APCI1710_Ttl.c
delete mode 100644 drivers/staging/comedi/drivers/addi-data/hwdrv_APCI1710.c
delete mode 100644 drivers/staging/comedi/drivers/addi_apci_1710.c
Seems fair enough as it's currently dead code anyway.
Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
