On Thu, Jul 25, 2013 at 10:19:31AM +0530, navin patidar wrote:
> >> - pr_warning("Unable to start control thread\n");
> >> + struct device *dev;
> >> +
> >> + if (ud->side == USBIP_STUB)
> >> + dev = &container_of(ud, struct stub_device, ud)->udev->dev;
> >> + else
> >> + dev = &container_of(ud, struct vhci_device, ud)->udev->dev;
> >
> > Putting '&' in front of container_of seems odd, are you sure it's needed
> > here? If ud is a pointer, everything else should "just work" properly
> > without that.
>
> Removing '&' caused following error.
> drivers/staging/usbip/usbip_event.c: In function ‘usbip_start_eh’:
> drivers/staging/usbip/usbip_event.c:93:8: error: incompatible types
> when assigning to type ‘struct device *’ from type ‘struct device’
> drivers/staging/usbip/usbip_event.c:95:8: error: incompatible types
> when assigning to type ‘struct device *’ from type ‘struct device’
>
> dev needs to be initialized with address of dev (struct device ) which
> is member of struct usb_device pointed by the udev.
>
> To make it more clear i can change it to
>
> dev = &(container_of(ud, struct vhci_device, ud)->udev->dev);
>
> or
>
> struct vhci_device *vdev = container_of(ud, struct vhci_device, ud);
> dev = &(vdev->udev->dev);
Or perhaps:
dev = container_of(ud, struct stub_device, ud).udev->dev;
or ->udev.dev; I don't remember which, but that should work, right?
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
