> -----Original Message----- > From: Greg KH [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > Sent: Tuesday, July 23, 2013 12:02 PM > To: KY Srinivasan > Cc: linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; olaf@xxxxxxxxx; > apw@xxxxxxxxxxxxx; andi@xxxxxxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; linux- > mm@xxxxxxxxx; kamezawa.hiroyuki@xxxxxxxxx; mhocko@xxxxxxx; > hannes@xxxxxxxxxxx; yinghan@xxxxxxxxxx; jasowang@xxxxxxxxxx; > kay@xxxxxxxx > Subject: Re: [PATCH 1/1] Drivers: base: memory: Export symbols for onlining > memory blocks > > On Fri, Jul 19, 2013 at 12:23:05PM -0700, K. Y. Srinivasan wrote: > > The current machinery for hot-adding memory requires having udev > > rules to bring the memory segments online. Export the necessary functionality > > to to bring the memory segment online without involving user space code. > > > > Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > > --- > > drivers/base/memory.c | 5 ++++- > > include/linux/memory.h | 4 ++++ > > 2 files changed, 8 insertions(+), 1 deletions(-) > > > > diff --git a/drivers/base/memory.c b/drivers/base/memory.c > > index 2b7813e..a8204ac 100644 > > --- a/drivers/base/memory.c > > +++ b/drivers/base/memory.c > > @@ -328,7 +328,7 @@ static int > __memory_block_change_state_uevent(struct memory_block *mem, > > return ret; > > } > > > > -static int memory_block_change_state(struct memory_block *mem, > > +int memory_block_change_state(struct memory_block *mem, > > unsigned long to_state, unsigned long from_state_req, > > int online_type) > > { > > @@ -341,6 +341,8 @@ static int memory_block_change_state(struct > memory_block *mem, > > > > return ret; > > } > > +EXPORT_SYMBOL(memory_block_change_state); > > EXPORT_SYMBOL_GPL() for all of these please. Will do. > > And as others have pointed out, I can't export symbols without a user of > those symbols going into the tree at the same time. So I'll drop this > patch for now and wait for your consumer of these symbols to be > submitted. I will submit the consumer as well. Thanks, K. Y > greg k-h > > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
