Re: [PATCH 2/2] staging: iio: replace strict_strto*() with kstrto*()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/23/2013 01:26 PM, Dan Carpenter wrote:
> On Tue, Jul 23, 2013 at 07:19:03PM +0900, Jingoo Han wrote:
>> diff --git a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
>> index 38a158b..03766bb 100644
>> --- a/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
>> +++ b/drivers/staging/iio/trigger/iio-trig-bfin-timer.c
>> @@ -87,7 +87,7 @@ static ssize_t iio_bfin_tmr_frequency_store(struct device *dev,
>>  	bool enabled;
>>  	int ret;
>>  
>> -	ret = strict_strtoul(buf, 10, &val);
>> +	ret = kstrtoul(buf, 10, &val);
>>  	if (ret)
>>  		goto error_ret;
>>  
> 
> Btw, this function is not beautiful.

The whole driver is not beautiful ;) It will eventually be replaced with
something more generic, I wouldn't put too much effort into cleaning it up.

- Lars
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux