On 07/17/2013 05:49 PM, Greg KH wrote:
On Wed, Jul 17, 2013 at 04:18:01PM -0400, Lidza Louina wrote:
This patch adds the Digi driver to staging.
Which digi driver? For what hardware? What type of driver is it?
Please provide some more details here.
From the readme:
This Digi software package includes device drivers for the PCI models
of the Digi Neo and ClassicBoard series of products.
It is currently supported on the following hardware platforms:
o Standard i386/i486 and Pentium PC (x86 32bit)
o x86 64bit
It builds. Needs work done
to adapt to the API changes.
Signed-off-by: Lidza Louina <lidza.louina@xxxxxxxxx>
If at all possible, can we attribute this to the original author(s)?
Are their names in the driver somewhere?
* Copyright 2003 Digi International (www.digi.com)
* Scott H Kilau <Scott_Kilau at digi dot com>
---
drivers/staging/dgnc/Makefile | 95 +
drivers/staging/dgnc/Makefile.inc | 81 +
How does it build in that there is no tie to the
drivers/staging/Makefile and drivers/staging/Kconfig files?
In looking at these files, it looks like this is still stand-alone,
which isn't ok for the kernel build process, this should be changed.
drivers/staging/dgnc/dgnc_cls.c | 1412 +++++++++++
drivers/staging/dgnc/dgnc_driver.c | 1028 ++++++++
drivers/staging/dgnc/dgnc_mgmt.c | 313 +++
drivers/staging/dgnc/dgnc_neo.c | 1977 +++++++++++++++
drivers/staging/dgnc/dgnc_proc.c | 1551 ++++++++++++
drivers/staging/dgnc/dgnc_sysfs.c | 761 ++++++
drivers/staging/dgnc/dgnc_trace.c | 187 ++
drivers/staging/dgnc/dgnc_tty.c | 3648 +++++++++++++++++++++++++++
drivers/staging/dgnc/include/CVS/Entries | 13 +
drivers/staging/dgnc/include/CVS/Repository | 1 +
drivers/staging/dgnc/include/CVS/Root | 1 +
No need to check CVS meta-files into a git tree :)
drivers/staging/dgnc/include/dgnc_cls.h | 90 +
drivers/staging/dgnc/include/dgnc_driver.h | 566 +++++
drivers/staging/dgnc/include/dgnc_kcompat.h | 91 +
drivers/staging/dgnc/include/dgnc_mgmt.h | 37 +
drivers/staging/dgnc/include/dgnc_neo.h | 157 ++
drivers/staging/dgnc/include/dgnc_pci.h | 77 +
drivers/staging/dgnc/include/dgnc_proc.h | 147 ++
drivers/staging/dgnc/include/dgnc_sysfs.h | 49 +
drivers/staging/dgnc/include/dgnc_trace.h | 45 +
drivers/staging/dgnc/include/dgnc_tty.h | 42 +
drivers/staging/dgnc/include/dgnc_types.h | 36 +
drivers/staging/dgnc/include/digi.h | 419 +++
drivers/staging/dgnc/include/dpacompat.h | 115 +
All of these .h files should be in the drivers/staging/dgnc/ directory,
no need to put the in a separate include directory.
thanks,
greg k-h
.
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
