> -----Original Message----- > From: Tomas Hozza [mailto:thozza@xxxxxxxxxx] > Sent: Thursday, June 27, 2013 7:53 AM > To: gregkh@xxxxxxxxxxxxxxxxxxx > Cc: jasowang@xxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx; KY Srinivasan; Haiyang > Zhang; Tomas Hozza > Subject: [PATCH 1/3] tools: hv: Improve error logging in VSS daemon. > > Use errno and strerror() when logging errors to provide more > information. > > Signed-off-by: Tomas Hozza <thozza@xxxxxxxxxx> Signed-off-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > --- > tools/hv/hv_vss_daemon.c | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/tools/hv/hv_vss_daemon.c b/tools/hv/hv_vss_daemon.c > index fea03a3..64112e1 100644 > --- a/tools/hv/hv_vss_daemon.c > +++ b/tools/hv/hv_vss_daemon.c > @@ -156,7 +156,8 @@ int main(void) > > fd = socket(AF_NETLINK, SOCK_DGRAM, NETLINK_CONNECTOR); > if (fd < 0) { > - syslog(LOG_ERR, "netlink socket creation failed; error:%d", fd); > + syslog(LOG_ERR, "netlink socket creation failed; error:%d %s", > + errno, strerror(errno)); > exit(EXIT_FAILURE); > } > addr.nl_family = AF_NETLINK; > @@ -167,7 +168,7 @@ int main(void) > > error = bind(fd, (struct sockaddr *)&addr, sizeof(addr)); > if (error < 0) { > - syslog(LOG_ERR, "bind failed; error:%d", error); > + syslog(LOG_ERR, "bind failed; error:%d %s", errno, > strerror(errno)); > close(fd); > exit(EXIT_FAILURE); > } > @@ -187,7 +188,7 @@ int main(void) > > len = netlink_send(fd, message); > if (len < 0) { > - syslog(LOG_ERR, "netlink_send failed; error:%d", len); > + syslog(LOG_ERR, "netlink_send failed; error:%d %s", errno, > strerror(errno)); > close(fd); > exit(EXIT_FAILURE); > } > @@ -241,7 +242,8 @@ int main(void) > vss_msg->error = error; > len = netlink_send(fd, incoming_cn_msg); > if (len < 0) { > - syslog(LOG_ERR, "net_link send failed; error:%d", len); > + syslog(LOG_ERR, "net_link send failed; error:%d %s", > + errno, strerror(errno)); > exit(EXIT_FAILURE); > } > } > -- > 1.8.1.4 > > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
