On 06/07/2013 05:40 PM, Jerome Marchand wrote: > On 06/07/2013 10:09 AM, Minchan Kim wrote: >> On Fri, Jun 07, 2013 at 12:07:26AM +0800, Jiang Liu wrote: >>> Function valid_io_request() should verify the entire request are within ... >>> >>> + start = bio->bi_sector; >>> + end = start + (bio->bi_size >> SECTOR_SHIFT); >>> + bound = zram->disksize >> SECTOR_SHIFT; >>> + /* out of range range */ >>> + if (unlikely(start >= bound || end >= bound || start > end)) >> >> if (end >= bound || start > end) isn't enough? > > I shall think so. > > Jerome Me too! But I realized this just after sending out the patchset last night. > >> >>> return 0; >>> - } >>> >>> /* I/O request is valid */ >>> return 1; >>> -- >>> 1.8.1.2 >>> >>> -- >>> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >>> the body of a message to majordomo@xxxxxxxxxxxxxxx >>> More majordomo info at http://vger.kernel.org/majordomo-info.html >>> Please read the FAQ at http://www.tux.org/lkml/ >> > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
