Re: [PATCH 1/1] keucr: restored lost line

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Jun 06, 2013 at 10:50:51PM +0200, Laura Lawniczak wrote:
> This line was unfortunately removed during patch process. This caused an
> "unused variable" warning and may cause other unintended effects.
> So here it is again.
> 

Oh wow...  I noticed this in the first patch and I couldn't figure
out why the blen = 0 was there...  It never occurred to me that it
was to silence the warning.  :P  That's hilarious.

The blen variable is only used in commented out code.  Don't do
this.  Please delete everything to do with blen.  It's there in the
history if anyone wants to see it.  Delete "bn" as well.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux