On Thu, Jun 06, 2013 at 06:10:49PM +0200, Johannes Schilling wrote: > From: Laura Lawniczak <laura.lawniczak@xxxxxxxxxxxxxx> > > Function usb_stor_print_cmd was declared in init.c but only used > in transport.c. So it was reasonable to move it there and declare > it static > > Signed-off-by: Laura Lawniczak <laura.lawniczak@xxxxxxxxxxxxxx> Don't forget your Signed-off-by, Johannes, since it's coming from you. Can you resend this? There are a couple small changes between the original and the moved function. 1) "blen = 0" is removed from the last line. This doesn't cause a bug. In a later patch you can remove the "bn = 0" as well. 2) A comma was deleted after the string in the commented code so it now has a syntax error: > + /* dev_dbg( > + &us->pusb_dev->dev, "scsi cmd %X --- SCSIOP_READ,bn = %X, blen = %X\n" > + cmd, bn, blen); */ It's better if you just do a straight move and change things in a later patch. But for now it's fine. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
