[PATCH v3 00/10] staging: octeon-usb: cvmx-usbcx-defs.h cleanup

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

This series fixes some of the checkpatch issues in cvmx-usbcx-defs.h,
and drops unused code:

Before: 1785 errors, 1168 warnings, 3086 lines checked
 After:  193 errors,   23 warnings, 1551 lines checked

Remaining errors are caused by "ERROR: spaces prohibited around that ':'
(ctx:WxW)". It seems checkpatch does not agree on the bitfield placements
(bug?).

Other remaining issue is "WARNING: do not add new typedefs" which will
be addressed in further cleanups of the driver.

There should be no functional changes. Verified as follows:

	- mips-linux-gnu-size reports the same binary size before/after
	  for octeon-usb.ko (compiled binary of the driver).

	- USB mass storage functionality tested with EdgeRouter Lite with
	  the new patches.

History:

	v3: Replace Lindent run with manual cleanups.
	    Delete unused data types.
	    Rename helper macros for register access.

	v2: Handle CVMX_ macros differently.
	    http://marc.info/?l=linux-driver-devel&m=137046823325129&w=2

	v1: http://marc.info/?l=linux-driver-devel&m=137038157225950&w=2

A.

Aaro Koskinen (10):
  staging: octeon-usb: cvmx-usbcx-defs.h: delete unused data types
  staging: octeon-usb: cvmx-usbcx-defs.h: delete unused union members
  staging: octeon-usb: cvmx-usbcx-defs.h: fix brace placement
  staging: octeon-usb: cvmx-usbcx-defs.h: fix struct indentation
  staging: octeon-usb: cvmx-usbcx-defs.h: fix comment style
  staging: octeon-usb: cvmx-usbcx-defs.h: delete unused macros
  staging: octeon-usb: cvmx-usbcx-defs.h: clean up macros
  staging: octeon-usb: cvmx-usbcx-defs.h: avoid long lines in comments
  staging: octeon-usb: cvmx-usbcx-defs.h: delete CVS keyword marker
  staging: octeon-usb: cvmx-usbcx-defs.h: reformat license text to fit
    80 cols

 drivers/staging/octeon-usb/cvmx-usbcx-defs.h | 4011 ++++++++------------------
 1 file changed, 1238 insertions(+), 2773 deletions(-)

-- 
1.7.10.4

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux