> -----Original Message----- > From: Greg Kroah-Hartman [mailto:gregkh@xxxxxxxxxxxxxxxxxxx] > Sent: Tuesday, June 04, 2013 10:00 PM > To: Peng, Tao > Cc: Stephen Rothwell; devel@xxxxxxxxxxxxxxxxxxxx; linux-next@xxxxxxxxxxxxxxx; Andreas Dilger > Subject: Re: [PATCH] staging/lustre: fix build errors > > On Tue, Jun 04, 2013 at 08:45:41AM +0000, Peng, Tao wrote: > > >From 369398c782c914e5f0548d5bbad22c00c6b58b6a Mon Sep 17 00:00:00 2001 > > From: Peng Tao <bergwolf@xxxxxxxxx> > > Date: Tue, 4 Jun 2013 15:48:17 +0800 > > Subject: [PATCH] staging/lustre: fix build errors > > Why send me the whole patch header? If I want to apply this, I need to > hand edit it. > Sorry... won't do it again. > > There are several issues: > > 1. set_cpus_allowed() is not available with CONFIG_CPUMASK_OFFSTACK on > > 2. CONFIG_MODULES may not be defined > > 3. CONFIG_MODULE_UNLOAD may not be defined > > You did three different things, please send 3 different patches, I can't > take this as is. > OK. Will split, fix up and resend. > > diff --git a/drivers/staging/lustre/lustre/obdclass/lu_object.c > b/drivers/staging/lustre/lustre/obdclass/lu_object.c > > index 1cbbb6f..da459e1 100644 > > --- a/drivers/staging/lustre/lustre/obdclass/lu_object.c > > +++ b/drivers/staging/lustre/lustre/obdclass/lu_object.c > > @@ -1351,7 +1351,9 @@ static void key_fini(struct lu_context *ctx, int index) > > > > LASSERT(key->lct_owner != NULL); > > if ((ctx->lc_tags & LCT_NOREF) == 0) { > > +#ifdef CONFIG_MODULE_UNLOAD > > LINVRNT(module_refcount(key->lct_owner) > 0); > > +#endif > > What is that? What is LINVRNT? > It is like ASSERT/BUG_ON, but needs extra config, which seems to be mistakenly removed by coan (which I used to cleanup Lustre code from the first place). I will add it back. > > module_put(key->lct_owner); > > Are you sure this isn't racy? > Which race do you refer to, please? module is pined by each key in keys_fill(), so we drop the reference here. > > } > > ctx->lc_value[index] = NULL; > > @@ -1933,7 +1935,11 @@ void lu_context_keys_dump(void) > > i, key, key->lct_tags, > > key->lct_init, key->lct_fini, key->lct_exit, > > key->lct_index, atomic_read(&key->lct_used), > > +#ifdef CONFIG_MODULES > > key->lct_owner ? key->lct_owner->name : "", > > +#else > > + "", > > +#endif > > That's a mess, why care about a module name at all? > Will remove it. Thanks. Cheers, Tao _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
