Hi Jiang,
Could you please state the changes that happened between v1 and v2.
That would be really helpful to the reviewers, and probably even more
useful to the maintainer.
Thanks,
Jerome
On 06/04/2013 06:05 PM, Jiang Liu wrote:
> Now there's no caller of zram_get_num_devices(), so kill it.
> And change zram_devices to static because it's only used in zram_drv.c.
>
> Signed-off-by: Jiang Liu <jiang.liu@xxxxxxxxxx>
> ---
> drivers/staging/zram/zram_drv.c | 7 +------
> drivers/staging/zram/zram_drv.h | 2 --
> 2 files changed, 1 insertion(+), 8 deletions(-)
>
> diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c
> index e34e3fe..0a07de4 100644
> --- a/drivers/staging/zram/zram_drv.c
> +++ b/drivers/staging/zram/zram_drv.c
> @@ -37,7 +37,7 @@
>
> /* Globals */
> static int zram_major;
> -struct zram *zram_devices;
> +static struct zram *zram_devices;
>
> /* Module params (documentation at end) */
> static unsigned int num_devices = 1;
> @@ -669,11 +669,6 @@ static void destroy_device(struct zram *zram)
> blk_cleanup_queue(zram->queue);
> }
>
> -unsigned int zram_get_num_devices(void)
> -{
> - return num_devices;
> -}
> -
> static int __init zram_init(void)
> {
> int ret, dev_id;
> diff --git a/drivers/staging/zram/zram_drv.h b/drivers/staging/zram/zram_drv.h
> index 2d1a3f1..a18b66d 100644
> --- a/drivers/staging/zram/zram_drv.h
> +++ b/drivers/staging/zram/zram_drv.h
> @@ -109,8 +109,6 @@ struct zram {
> struct zram_stats stats;
> };
>
> -extern struct zram *zram_devices;
> -unsigned int zram_get_num_devices(void);
> #ifdef CONFIG_SYSFS
> extern struct attribute_group zram_disk_attr_group;
> #endif
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
