On Wed, Jun 05, 2013 at 12:06:04AM +0800, Jiang Liu wrote: > Function valid_io_request() should verify the entire request doesn't > exceed the zram device, otherwise it will cause invalid memory access. Right but you need to explain what invalid memory access is and what's the result from that to user. > > Signed-off-by: Jiang Liu <jiang.liu@xxxxxxxxxx> > Cc: stable@xxxxxxxxxxxxxxx > --- > drivers/staging/zram/zram_drv.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/drivers/staging/zram/zram_drv.c b/drivers/staging/zram/zram_drv.c > index 6a54bb9..1c3974f 100644 > --- a/drivers/staging/zram/zram_drv.c > +++ b/drivers/staging/zram/zram_drv.c > @@ -428,6 +428,10 @@ static inline int valid_io_request(struct zram *zram, struct bio *bio) > return 0; > } > > + if (unlikely((bio->bi_sector << SECTOR_SHIFT) + bio->bi_size >= > + zram->disksize)) > + return 0; > + > /* I/O request is valid */ > return 1; > } > -- > 1.8.1.2 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- Kind regards, Minchan Kim _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
