> -----Original Message----- > From: Tomas Hozza [mailto:thozza@xxxxxxxxxx] > Sent: Wednesday, May 22, 2013 8:55 AM > To: gregkh@xxxxxxxxxxxxxxxxxxx > Cc: KY Srinivasan; jasowang@xxxxxxxxxx; Haiyang Zhang; > devel@xxxxxxxxxxxxxxxxxxxxxx; Tomas Hozza > Subject: [PATCH v3 3/4] tools: hv: Check retrun value of strchr call > > Check return value of strchr call and dereference it only if it is > not NULL. > > Signed-off-by: Tomas Hozza <thozza@xxxxxxxxxx> Acked-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx> > --- > tools/hv/hv_kvp_daemon.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c > index 81cbb6e..5b8f28f 100644 > --- a/tools/hv/hv_kvp_daemon.c > +++ b/tools/hv/hv_kvp_daemon.c > @@ -765,7 +765,9 @@ static void kvp_process_ipconfig_file(char *cmd, > break; > > x = strchr(p, '\n'); > - *x = '\0'; > + if (x) > + *x = '\0'; > + > strcat(config_buf, p); > strcat(config_buf, ";"); > } > -- > 1.8.1.4 > > _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel