RE: [PATCH v3 1/4] tools: hv: Check return value of setsockopt call

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




> -----Original Message-----
> From: Tomas Hozza [mailto:thozza@xxxxxxxxxx]
> Sent: Wednesday, May 22, 2013 8:55 AM
> To: gregkh@xxxxxxxxxxxxxxxxxxx
> Cc: KY Srinivasan; jasowang@xxxxxxxxxx; Haiyang Zhang;
> devel@xxxxxxxxxxxxxxxxxxxxxx; Tomas Hozza
> Subject: [PATCH v3 1/4] tools: hv: Check return value of setsockopt call
> 
> Check return value of setsockopt call and if it fails print error
> to the system log and exit with non-zero value.
> 
> Signed-off-by: Tomas Hozza <thozza@xxxxxxxxxx>

Acked-by: K. Y. Srinivasan <kys@xxxxxxxxxxxxx>
> ---
>  tools/hv/hv_kvp_daemon.c | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/hv/hv_kvp_daemon.c b/tools/hv/hv_kvp_daemon.c
> index 5a1f648..ae9aa1c 100644
> --- a/tools/hv/hv_kvp_daemon.c
> +++ b/tools/hv/hv_kvp_daemon.c
> @@ -1457,7 +1457,13 @@ int main(void)
>  		exit(EXIT_FAILURE);
>  	}
>  	nl_group = CN_KVP_IDX;
> -	setsockopt(fd, SOL_NETLINK, NETLINK_ADD_MEMBERSHIP, &nl_group,
> sizeof(nl_group));
> +
> +	if (setsockopt(fd, SOL_NETLINK, NETLINK_ADD_MEMBERSHIP,
> &nl_group, sizeof(nl_group)) < 0) {
> +		syslog(LOG_ERR, "setsockopt failed; error: %d %s", errno,
> strerror(errno));
> +		close(fd);
> +		exit(EXIT_FAILURE);
> +	}
> +
>  	/*
>  	 * Register ourselves with the kernel.
>  	 */
> --
> 1.8.1.4
> 
> 


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux