On Thu, May 30, 2013 at 06:51:48PM +0530, Harsh Kumar wrote: > The v2 patch will be over & above the changes that have been by my > previous patch, right? A v2 patch is a replacement for the first patch. There is a formula to it: 1) Reply to the original patch. 2) The subject changes to [patch v2] Staging: winbond: Made local functions static 3) Use the same changelog as before. 4) After the signed off by line put: --- v2: whitespace changes That line gets chopped out of the commit message save in the git log. 5) The same patch but without the whitespace changes Btw, once Greg sends you an email that your patch has been applied then it's too late to send a v2 patch and everything needs to be done as a separate patch. I feel like if Greg has already merged the patch then just forget about it. We'll fix it up later. No worries. Patch review isn't meant as a punishment for newbie stuff. ;) regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel