Re: [PATCH 2/4] ozwpan: replace alloc_skb with dev_alloc_skb in ozproto.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/23/2013 09:29 PM, Dan Carpenter wrote:
On Thu, May 23, 2013 at 08:51:57PM +0300, Xenia Ragiadakou wrote:
This patch replaces the calls to alloc_skb with calls
to dev_alloc_skb.

dev_alloc_skb has GFP_ATOMIC priority so the
replacement does not change the code semantics.

I don't think this change is correct.  What problem are you trying
to solve?  Perhaps we can help you.  Also the reason for the change
should be described in the changelog.

regards,
dan carpenter


Well, i was reading a tutorial on linux networking where it
was suggested to use dev_alloc_skb() instead of alloc_skb()
in drivers.

As I told you, I am not at all experienced.
Where is appropriate to use dev_alloc_skb()?
Can you give me an insight?

Ksenia
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux