On Thu, May 23, 2013 at 05:14:49AM +0300, Xenia Ragiadakou wrote:
> This patch fixes the following checkpatch warning:
> WARNING: printk() should include KERN_ facility level
> and also replaces calls to printk(KERN_ fmt, ...) with
> their corresponding calls to pr_ (fmt, ...), defined in
> include/linux/printk.h, to save space.
>
> Signed-off-by: Xenia Ragiadakou <burzalodowa@xxxxxxxxx>
> ---
> drivers/staging/rtl8192u/r8192U_core.c | 88 ++++++++++++++++----------------
> 1 file changed, 43 insertions(+), 45 deletions(-)
>
> diff --git a/drivers/staging/rtl8192u/r8192U_core.c b/drivers/staging/rtl8192u/r8192U_core.c
> index f790292..f798c95 100644
> --- a/drivers/staging/rtl8192u/r8192U_core.c
> +++ b/drivers/staging/rtl8192u/r8192U_core.c
> @@ -285,7 +285,7 @@ void write_nic_byte_E(struct net_device *dev, int indx, u8 data)
>
> if (status < 0)
> {
> - printk("write_nic_byte_E TimeOut! status:%d\n", status);
> + pr_err("write_nic_byte_E TimeOut! status:%d\n", status);
You have a network device pointer in this function, so you should use
net_dev* instead of pr_err(), right?
Can you fix this one patch up that way to use those functions instead of
pr_err()? I'll take your first 3 patches, they looked fine.
thanks,
greg k-h
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
