Cleanup and make comedi_load_firmware(), currently in the jr3_pci driver, a generic helper function that is exported by the comedi core. Use the exported helper in the comedi drivers instead of duplicating the code privately. The usbdux* drivers currently use request_firmware_nowait() to get the firmware image asynchronously. The usbduxfast driver has already been converted to use request_firmware() but the patches have not shown up on linux-next yet. I will submit a patch to use the the exported helper in this driver as soon as they do. The usbdux and usbduxsigma drivers will also be converted to request the firmware synchronously and use the exported helper. H Hartley Sweeten (6): staging: comedi: jr3_pci: use kasprintf staging: comedi: jr3_pci: tidy up comedi_load_firmware() staging: comedi: drivers: generalize comedi_load_firmware() staging: comedi: daqboard2000: use comedi_load_firmware() staging: comedi: me_daq: use comedi_load_firmware() staging: comedi: ni_pcidio: use comedi_load_firmware() drivers/staging/comedi/comedidev.h | 7 ++++ drivers/staging/comedi/drivers.c | 33 +++++++++++++++++++ drivers/staging/comedi/drivers/daqboard2000.c | 24 +++----------- drivers/staging/comedi/drivers/jr3_pci.c | 46 ++++++--------------------- drivers/staging/comedi/drivers/me_daq.c | 24 +++----------- drivers/staging/comedi/drivers/ni_pcidio.c | 25 +++++++-------- 6 files changed, 70 insertions(+), 89 deletions(-) -- 1.8.1.4 _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel