Hi Paul, On Tue, May 14, 2013 at 3:28 PM, Paul Bolle <pebolle@xxxxxxxxxx> wrote: > 0) I ran into two Kconfig oddities with the Dynamic Voltage and > Frequency Scaling (DVFS) option for the DSP Bridge driver (ie, Kconfig > symbol TIDSPBRIDGE_DVFS). > > 1) That Kconfig symbol depends on OMAP_PM_SRF. But OMAP_PM_SRF doesn't > exist in mainline. It seems it actually has never been part of mainline. > (Currently, the only related symbol seems to be OMAP_PM_NOOP.) So the > DVFS code in mainline has not been buildable ever since it got added in > v2.6.36. What is the reason for this dependency on OMAP_PM_SRF? Initially, it was meant to support custom kernels which had TI SRF PM (aka OMAP_PM_SRF), at some point it should have been migrated to OMAP_PM_NOOP but this didn't happen, according to the documentation OMAP_PM_NOOP is meant to be temporary, but I don't know its current status. > 2) TIDSPBRIDGE_DVFS also depends on CPU_FREQ. But in the code we see: > drivers/staging/tidspbridge/rmgr/node.c:1119:#if defined(CONFIG_TIDSPBRIDGE_DVFS) && !defined(CONFIG_CPU_FREQ) > drivers/staging/tidspbridge/rmgr/node.c:1170:#if defined(CONFIG_TIDSPBRIDGE_DVFS) && !defined(CONFIG_CPU_FREQ) > drivers/staging/tidspbridge/rmgr/node.c:1188:#if defined(CONFIG_TIDSPBRIDGE_DVFS) && !defined(CONFIG_CPU_FREQ) > drivers/staging/tidspbridge/rmgr/proc.c:1025:#if defined(CONFIG_TIDSPBRIDGE_DVFS) && !defined(CONFIG_CPU_FREQ) > drivers/staging/tidspbridge/rmgr/proc.c:1155:#if defined(CONFIG_TIDSPBRIDGE_DVFS) && !defined(CONFIG_CPU_FREQ) > drivers/staging/tidspbridge/rmgr/proc.c:1173:#if defined(CONFIG_TIDSPBRIDGE_DVFS) && !defined(CONFIG_CPU_FREQ) > > So either this dependency is incorrect or the node.c and prog.c code > needs some cleaning up. Which is it? Yes, this dependency is wrong... but node.c and proc.c could use a cleanup too. Please let me know if you want to work on these or would be happy with a Reported-by. Cheers, Omar _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
