RE: [RFC PATCH 20/30] staging: comedi: dt9812: factor the device reset out of dt9812_probe()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tuesday, May 07, 2013 6:21 AM, Ian Abbott wrote:
> On 2013-05-03 21:50, H Hartley Sweeten wrote:
>> When this driver is converted to the comedi (*auto_attach) mechanism
>> the device reset will be done during the (*auto_attach). To make the
>> conversion cleaner, factor the device reset out of the (*probe).
>>
>> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
>> Cc: Ian Abbott <abbotti@xxxxxxxxx>
>> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
>> ---
>>   drivers/staging/comedi/drivers/dt9812.c | 111 +++++++++++++++++++-------------
>>   1 file changed, 65 insertions(+), 46 deletions(-)
>>
>> diff --git a/drivers/staging/comedi/drivers/dt9812.c b/drivers/staging/comedi/drivers/dt9812.c
>> index 42a4a9d..cf8f10f 100644
>> --- a/drivers/staging/comedi/drivers/dt9812.c
>> +++ b/drivers/staging/comedi/drivers/dt9812.c
>> @@ -774,6 +774,69 @@ static int dt9812_find_endpoints(struct usb_interface *intf,
>>   	return 0;
>>   }
>>
>> +static int rt9812_reset_device(struct usb_interface *intf,
>> +			       struct usb_dt9812 *devpriv)
>
> Shouldn't that be called dt9812_reset_device?

Yup.. I'll fix it when I repost the series after the merge window closes.

Thanks,
Hartley

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux