On Mon, May 06, 2013 at 12:21:39PM +0530, Srinidhi Kasagar wrote: > > > > - regulator_enable(rmi4_data->regulator); > > > > + retval = regulator_enable(rmi4_data->regulator); > > > > + if (retval < 0) > > > > + return retval; > > > Does it make sense to add a dev_err? > > > > > > > Is that a question? > > > > regulator_enable() already prints some warnings. Probably it's not > > going to fail and adding code that is duplicative or will never be > > run is pointless. > > It has become a habit checking the return value and spit some errors. > And BTW, there are many drivers which does this way..Anyway if your > intention is to avoid them for the new drivers..I dont mind skipping > this.. It's not like I'm trying to ban error messages. There isn't any official policy on error messages. regards, dan carpenter _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
