Re: [PATCH] Staging: Panel: panel: Fixed checkpatch line length warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sat, May 04, 2013 at 11:21:17AM -0400, Jake Champlin wrote:
> @@ -1802,10 +1803,11 @@ static inline void input_state_falling(struct logical_input *input)
>  
>  			if (input->u.kbd.repeat_str[0]) {
>  				char *repeat_str = input->u.kbd.repeat_str;
> -				if (input->high_timer >= KEYPAD_REP_START)
> +				if (input->high_timer >= KEYPAD_REP_START) {
> +					int s = sizeof(input->u.kbd.repeat_str);
>  					input->high_timer -= KEYPAD_REP_DELAY;
> -					keypad_send_key(repeat_str,
> -							sizeof(input->u.kbd.repeat_str));
> +					keypad_send_key(repeat_str, s);
> +				}


This looks like a bugfix.  Good job.  Please mention bug fixes in
the changelog next time.

regards,
dan carpenter


_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux