On 03-05-2013 01:52, Sachin Kamat wrote: > Use IS_ERR instead of IS_ERR_OR_NULL on clk_get results. > > Signed-off-by: Sachin Kamat <sachin.kamat@xxxxxxxxxx> > Cc: Eduardo Valentin <eduardo.valentin@xxxxxx> > --- Sachin, I have a patch that covers this already: https://patchwork.kernel.org/patch/2488331/ Actually it does a wider job in this driver. I will resend it with proper amendments. Tks > drivers/staging/ti-soc-thermal/ti-bandgap.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/ti-soc-thermal/ti-bandgap.c b/drivers/staging/ti-soc-thermal/ti-bandgap.c > index f20c1cf..29746d0 100644 > --- a/drivers/staging/ti-soc-thermal/ti-bandgap.c > +++ b/drivers/staging/ti-soc-thermal/ti-bandgap.c > @@ -1207,14 +1207,14 @@ int ti_bandgap_probe(struct platform_device *pdev) > } > > bgp->fclock = clk_get(NULL, bgp->conf->fclock_name); > - ret = IS_ERR_OR_NULL(bgp->fclock); > + ret = IS_ERR(bgp->fclock); > if (ret) { > dev_err(&pdev->dev, "failed to request fclock reference\n"); > goto free_irqs; > } > > bgp->div_clk = clk_get(NULL, bgp->conf->div_ck_name); > - ret = IS_ERR_OR_NULL(bgp->div_clk); > + ret = IS_ERR(bgp->div_clk); > if (ret) { > dev_err(&pdev->dev, > "failed to request div_ts_ck clock ref\n"); >
Attachment:
signature.asc
Description: OpenPGP digital signature
_______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
