[RFC PATCH 24/39] staging: comedi: usbduxfast: rename 'insnBuffer' from private data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



This buffer space is kmalloc'ed and free'ed but never used. Just
remove it.

Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>
Cc: Ian Abbott <abbotti@xxxxxxxxx>
Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>
---
 drivers/staging/comedi/drivers/usbduxfast.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/drivers/staging/comedi/drivers/usbduxfast.c b/drivers/staging/comedi/drivers/usbduxfast.c
index c4fa437..ec1cf1c 100644
--- a/drivers/staging/comedi/drivers/usbduxfast.c
+++ b/drivers/staging/comedi/drivers/usbduxfast.c
@@ -153,7 +153,6 @@ static const struct comedi_lrange range_usbduxfast_ai_range = {
 struct usbduxfast_private {
 	struct urb *urb;	/* BULK-transfer handling: urb */
 	int8_t *transfer_buffer;
-	int16_t *insnBuffer;	/* input buffer for single insn */
 	short int ai_cmd_running;	/* asynchronous command is running */
 	short int ai_continous;	/* continous acquisition */
 	long int ai_sample_count;	/* number of samples to acquire */
@@ -1288,10 +1287,6 @@ static int usbduxfast_auto_attach(struct comedi_device *dev,
 	if (!devpriv->dux_commands)
 		return -ENOMEM;
 
-	devpriv->insnBuffer = kmalloc(SIZEINSNBUF, GFP_KERNEL);
-	if (!devpriv->insnBuffer)
-		return -ENOMEM;
-
 	ret = usb_set_interface(usb,
 				intf->altsetting->desc.bInterfaceNumber, 1);
 	if (ret < 0) {
@@ -1347,9 +1342,6 @@ static void usbduxfast_detach(struct comedi_device *dev)
 		devpriv->urb = NULL;
 	}
 
-	kfree(devpriv->insnBuffer);
-	devpriv->insnBuffer = NULL;
-
 	kfree(devpriv->dux_commands);
 	devpriv->dux_commands = NULL;
 
-- 
1.8.1.4

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux