On 2013-04-23 17:29, H Hartley Sweeten wrote:
On April 23, 2013 4:32 AM , Ian Abbott wrote:
On 2013-04-22 20:32, H Hartley Sweeten wrote:
Split the PCI support code out of ni_labpc and tidy up the driver
attach/detach.
H Hartley Sweeten (5):
staging: comedi: ni_labpc: split out PCI support
staging: comedi: ni_labpc: move DMA init out of the common attach
staging: comedi: ni_labpc: pass the isr_flags to labpc_common_attach()
staging: comedi: ni_labpc: remove unnecessary 'bustype' check
staging: comedi: ni_labpc: remove 'bustype' from boardinfo
drivers/staging/comedi/Kconfig | 35 ++--
drivers/staging/comedi/drivers/Makefile | 1 +
drivers/staging/comedi/drivers/ni_labpc.c | 241 ++++++--------------------
drivers/staging/comedi/drivers/ni_labpc.h | 4 +-
drivers/staging/comedi/drivers/ni_labpc_cs.c | 3 +-
drivers/staging/comedi/drivers/ni_labpc_pci.c | 142 +++++++++++++++
6 files changed, 225 insertions(+), 201 deletions(-)
create mode 100644 drivers/staging/comedi/drivers/ni_labpc_pci.c
Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>
Though I'm wondering whether or not AI command support on the ISA card
when no DMA channel is specified works the same as on PCMCIA.
My guess is that the AI command support works fine with just
Interrupts. But, the maximum acquisition rate would be lower.
For simplicity, and since this is a legacy driver, it might be worth just
stripping out the DMA support completely. It would make splitting
the ISA support out easier.
I'd rather keep the DMA support, maybe calling out to functions in a
separate module with a header file doing different things depending on
whether CONFIG_ISA_DMA_API is enabled.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
