Re: [PATCH 01/12] staging: comedi: drivers: introduce comedi_legacy_detach()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2013-04-18 11:36, Ian Abbott wrote:

An alternative implementation would be to leave
__comedi_request_region() alone, but change comedi_request_region() to
record the length in a new member dev->iolen at the same time that it
records the start address in dev->iobase.  Then your
comedi_legacy_detach() could do something like:

	if (dev->iolen) {
		release_region(dev->iobase, dev->iolen);
		dev->iolen = 0;
	}

I think it seems slightly simpler and shouldn't affect your other
patches.  Any thoughts?

Well it would conflict with your existing patch 10 slightly, but shouldn't affect the drivers.

--
-=( Ian Abbott @ MEV Ltd.    E-mail: <abbotti@xxxxxxxxx>        )=-
-=( Tel: +44 (0)161 477 1898   FAX: +44 (0)161 718 3587         )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux