> -----Original Message----- > From: David Miller [mailto:davem@xxxxxxxxxxxxx] > Sent: Tuesday, April 16, 2013 3:49 PM > To: Haiyang Zhang > Cc: netdev@xxxxxxxxxxxxxxx; KY Srinivasan; olaf@xxxxxxxxx; jasowang@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; devel@xxxxxxxxxxxxxxxxxxxxxx > Subject: Re: [PATCH net] hyperv: Fix a compiler warning in netvsc_send() > > From: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx> > Date: Tue, 16 Apr 2013 19:34:52 +0000 > > > The Hyper-V hosts always use 64 bit request id. The guests can have > > 32 or 64 bit pointers which equal to the ulong type size. So we cast > > it to ulong type. And, assigning 32bit integer to 64 bit variable > > works fine. > > It works fine, but it's unclean. > > Keep the req_id type as "u64", because that's what it is, a 64-bit request ID. I will make this update and submit a new patch, with the added comments. Thanks, - Haiyang _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
