Re: [PATCH V2] staging: ced1401: kfree the pdx at err path and remove callback

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 15, 2013 at 6:29 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> On Mon, Apr 15, 2013 at 04:51:50PM +0530, Devendra Naga wrote:
>> leak introduced since pdx is not freed, free it at err path and
>> at remove callback
>>
>
> The original code is correct and this patch introduces a double
> free bug.  ced_delete() already calls kfree(pdx).

ok thanks, sorry i will read the code more carefully before submitting
any patch.


>
> regards,
> dan carpenter
>
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux