RE: [PATCH] staging: comedi: amplc_dio200_pci: use pci_ioremap_bar()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Friday, April 12, 2013 5:01 AM, Ian Abbott wrote:
> Use `pci_ioremap_bar()` to ioremap the PCI memory resources.  That
> function just takes the PCI device and a bar index.  It also has some
> additional sanity checks to make sure the bar is actually a memory
> resource.
>
> Eliminate some local variables from `dio200_pcie_board_setup()` and
> `dio200_pci_auto_attach()` that were used to hold the results of
> `pci_resource_len()` and `pci_resource_start()` that were only used
> once.  Also eliminate the check that the bar is a memory resource in
> `dio200_pcie_board_setup()` as `pci_ioremap_bar()` will do that for us.
>
> Signed-off-by: Ian Abbott <abbotti@xxxxxxxxx>
> ---
>  drivers/staging/comedi/drivers/amplc_dio200_pci.c | 16 +++++-----------
>  1 file changed, 5 insertions(+), 11 deletions(-)

Reviewed-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx>

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux