On Thursday, April 11, 2013 3:02 AM, Ian Abbott wrote: > On 2013-04-10 19:32, H Hartley Sweeten wrote: >> This comment about using ioremap() for 2.4 kernels is not necessary. >> >> Signed-off-by: H Hartley Sweeten <hsweeten@xxxxxxxxxxxxxxxxxxx> >> Cc: Ian Abbott <abbotti@xxxxxxxxx> >> Cc: Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx> >> --- >> drivers/staging/comedi/drivers/ii_pci20kc.c | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/drivers/staging/comedi/drivers/ii_pci20kc.c b/drivers/staging/comedi/drivers/ii_pci20kc.c >> index 03719f2..ee7537d 100644 >> --- a/drivers/staging/comedi/drivers/ii_pci20kc.c >> +++ b/drivers/staging/comedi/drivers/ii_pci20kc.c >> @@ -77,9 +77,6 @@ options for PCI-20341M: >> 3 200 >> */ >> >> -/* XXX needs to use ioremap() for compatibility with 2.4 kernels. Should also >> - * check_mem_region() etc. - fmhess */ >> - >> #include "../comedidev.h" >> >> #define PCI20000_ID 0x1d >> > > This is a pretty stupid and broken driver anyway. We should probably > get rid of it as there's no way it could actually function in its > current state. I'm ok with dropping this one. For one thing it's a PCI driver that is presented as a legacy device... Ugly... I did a quick look on the web to try and find a register level manual for the hardware this driver is "supposed" to work with. I found the Intelligent Instrumentation website at http://www.instrument.com but could not locate anything for a PCI-20006 or PCI-20341 board. Your call. Regards, Hartley _______________________________________________ devel mailing list devel@xxxxxxxxxxxxxxxxxxxxxx http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
