RE: [PATCH 00/18] staging: comedi: use pci_ioremap_bar()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thursday, April 11, 2013 3:03 AM, Ian Abbott wrote:
> On 2013-04-10 19:25, H Hartley Sweeten wrote:
>> Use pci_ioremap_bar() instead of ioremap(). This makes sure the entire
>> pci bar is ioremap'ed instead of assuming a size. pci_ioremap_bar()
>> also does additional sanity checking to make sure the bar is a memory
>> resource.
>>
>> Remove some cruft from the drivers associated with the ioremapping.
>>

<snip>

> All looks good.
>
> Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>
>
> (Don't bother adding the line if it's too much bother, Greg.)

Thanks.

The amplc_dio200_pci driver is the only one that still does the ioremap
with something other than pci_ioremap_bar().

Can you take a look at it and see if it can be converted?

Thanks,
Hartley

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux