Re: [PATCH 1/3] staging: speakup: reuse native kernel functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Apr 09, 2013 at 03:06:06PM +0300, Andy Shevchenko wrote:
> On Mon, 2013-04-01 at 12:18 +0300, Dan Carpenter wrote: 
> > On Wed, Mar 27, 2013 at 05:44:55PM +0200, Andy Shevchenko wrote:
> > > We have simple_strtoul and simple_strtol. Don't repeat their functionality
> > > here.
> > > 
> > 
> > Run your patches through checkpatch.pl.  It will tell you do use
> > kstrtoul() instead of simple_strtoul().
> 
> Unfortunately kstrto* have limitation - it works only on null-terminated
> "number" strings, which is not a case here and in many other places in
> kernel where input is more complicated than just a plain number in ascii
> form.

Fair point.

regards,
dan carpenter

_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel




[Index of Archives]     [Linux Driver Backports]     [DMA Engine]     [Linux GPIO]     [Linux SPI]     [Video for Linux]     [Linux USB Devel]     [Linux Coverity]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [Yosemite Backpacking]
  Powered by Linux