On 2013-04-08 18:54, H Hartley Sweeten wrote:
Initialize the dev->board_name in the comedi core before calling the (*attach)
or (*auto_attach) function.
Remove all the iitialization of the dev->board_name in the comedi drivers.
H Hartley Sweeten (5):
staging: comedi: drivers: rename 'comedi_dev' in comedi_auto_config()
staging: comedi: drivers: set dev->board_name before attaching
staging: comedi: drivers: dev->board_name is always valid
staging: comedi: comedi_pci: dev->board_name is always valid
staging: comedi: remove unnecessary dev->board_name initialization
drivers/staging/comedi/comedi_pci.c | 4 +---
drivers/staging/comedi/drivers.c | 30 +++++++++++-------------
drivers/staging/comedi/drivers/8255.c | 2 --
drivers/staging/comedi/drivers/addi_apci_1032.c | 2 --
drivers/staging/comedi/drivers/addi_apci_1710.c | 2 --
drivers/staging/comedi/drivers/addi_apci_2032.c | 2 --
drivers/staging/comedi/drivers/addi_apci_2200.c | 2 --
drivers/staging/comedi/drivers/addi_apci_3501.c | 2 --
drivers/staging/comedi/drivers/adl_pci8164.c | 2 --
drivers/staging/comedi/drivers/adl_pci9111.c | 2 --
drivers/staging/comedi/drivers/adq12b.c | 2 --
drivers/staging/comedi/drivers/adv_pci1723.c | 2 --
drivers/staging/comedi/drivers/adv_pci1724.c | 2 --
drivers/staging/comedi/drivers/aio_iiro_16.c | 2 --
drivers/staging/comedi/drivers/c6xdigio.c | 1 -
drivers/staging/comedi/drivers/cb_pcimdas.c | 2 --
drivers/staging/comedi/drivers/cb_pcimdda.c | 2 --
drivers/staging/comedi/drivers/comedi_parport.c | 2 --
drivers/staging/comedi/drivers/comedi_test.c | 2 --
drivers/staging/comedi/drivers/contec_pci_dio.c | 2 --
drivers/staging/comedi/drivers/das16m1.c | 2 --
drivers/staging/comedi/drivers/das6402.c | 2 --
drivers/staging/comedi/drivers/dmm32at.c | 2 --
drivers/staging/comedi/drivers/dt2814.c | 1 -
drivers/staging/comedi/drivers/dt2815.c | 1 -
drivers/staging/comedi/drivers/dt2817.c | 1 -
drivers/staging/comedi/drivers/dt9812.c | 2 --
drivers/staging/comedi/drivers/dyna_pci10xx.c | 2 --
drivers/staging/comedi/drivers/fl512.c | 1 -
drivers/staging/comedi/drivers/icp_multi.c | 2 --
drivers/staging/comedi/drivers/ii_pci20kc.c | 1 -
drivers/staging/comedi/drivers/jr3_pci.c | 1 -
drivers/staging/comedi/drivers/ke_counter.c | 2 --
drivers/staging/comedi/drivers/mpc624.c | 1 -
drivers/staging/comedi/drivers/multiq3.c | 1 -
drivers/staging/comedi/drivers/ni_daq_700.c | 2 --
drivers/staging/comedi/drivers/ni_daq_dio24.c | 2 --
drivers/staging/comedi/drivers/pcl725.c | 1 -
drivers/staging/comedi/drivers/pcm3724.c | 2 --
drivers/staging/comedi/drivers/pcm3730.c | 1 -
drivers/staging/comedi/drivers/pcmda12.c | 2 --
drivers/staging/comedi/drivers/pcmmio.c | 2 --
drivers/staging/comedi/drivers/quatech_daqp_cs.c | 2 --
drivers/staging/comedi/drivers/rti802.c | 2 --
drivers/staging/comedi/drivers/s526.c | 2 --
drivers/staging/comedi/drivers/s626.c | 2 --
drivers/staging/comedi/drivers/serial2002.c | 1 -
drivers/staging/comedi/drivers/skel.c | 10 ++++----
drivers/staging/comedi/drivers/ssv_dnp.c | 2 --
drivers/staging/comedi/drivers/unioxx5.c | 1 -
drivers/staging/comedi/drivers/usbdux.c | 2 --
drivers/staging/comedi/drivers/usbduxfast.c | 2 +-
drivers/staging/comedi/drivers/usbduxsigma.c | 2 +-
53 files changed, 23 insertions(+), 108 deletions(-)
They all look fine to me.
Reviewed-by: Ian Abbott <abbotti@xxxxxxxxx>
(P.S. Hartley, I don't know if you plan to resubmit those other changes
you had that passed a "main" PCI BAR index to comedi_pci_enable(), but I
don't think they're as useful now as they were when you initially
submitted them, so I wouldn't bother if I were you.)
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@xxxxxxxxx> )=-
-=( Tel: +44 (0)161 477 1898 FAX: +44 (0)161 718 3587 )=-
_______________________________________________
devel mailing list
devel@xxxxxxxxxxxxxxxxxxxxxx
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel
